require 'spec_helper'
describe 'delete_undef_values' do
+ let(:is_puppet_6) { Puppet::Util::Package.versioncmp(Puppet.version, '6.0.0') == 0 }
+
it { is_expected.not_to eq(nil) }
- it { is_expected.to run.with_params().and_raise_error(Puppet::ParseError) }
- it { is_expected.to run.with_params(1).and_raise_error(Puppet::ParseError) }
- it { is_expected.to run.with_params('one').and_raise_error(Puppet::ParseError) }
- it { is_expected.to run.with_params('one', 'two').and_raise_error(Puppet::ParseError) }
+ it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError, %r{Wrong number of arguments}) }
+ it { is_expected.to run.with_params(1).and_raise_error(Puppet::ParseError, %r{expected an array or hash}) }
+ it { is_expected.to run.with_params('one').and_raise_error(Puppet::ParseError, %r{expected an array or hash}) }
+ it { is_expected.to run.with_params('one', 'two').and_raise_error(Puppet::ParseError, %r{expected an array or hash}) }
describe 'when deleting from an array' do
- [ :undef, '', nil ].each do |undef_value|
+ # Behavior is different in Puppet 6.0.0, and fixed in PUP-9180 in Puppet 6.0.1
+ [:undef, '', nil].each do |undef_value|
describe "when undef is represented by #{undef_value.inspect}" do
- before do
+ before(:each) do
pending("review behaviour when being passed undef as #{undef_value.inspect}") if undef_value == ''
- pending("review behaviour when being passed undef as #{undef_value.inspect}") if undef_value == nil
+ pending("review behaviour when being passed undef as #{undef_value.inspect}") if undef_value == :undef && is_puppet_6
end
it { is_expected.to run.with_params([undef_value]).and_return([]) }
- it { is_expected.to run.with_params(['one',undef_value,'two','three']).and_return(['one','two','three']) }
- it { is_expected.to run.with_params(['ớņέ',undef_value,'ŧשּׁō','ŧħґëə']).and_return(['ớņέ','ŧשּׁō','ŧħґëə']) }
+ it { is_expected.to run.with_params(['one', undef_value, 'two', 'three']).and_return(['one', 'two', 'three']) }
+ it { is_expected.to run.with_params(['ớņέ', undef_value, 'ŧשּׁō', 'ŧħґëə']).and_return(['ớņέ', 'ŧשּׁō', 'ŧħґëə']) }
end
- it "should leave the original argument intact" do
- argument = ['one',undef_value,'two']
+ it 'leaves the original argument intact' do
+ argument = ['one', undef_value, 'two']
original = argument.dup
- result = subject.call([argument,2])
+ _result = subject.execute(argument, 2)
expect(argument).to eq(original)
end
end
end
describe 'when deleting from a hash' do
- [ :undef, '', nil ].each do |undef_value|
+ [:undef, '', nil].each do |undef_value|
describe "when undef is represented by #{undef_value.inspect}" do
- before do
+ before(:each) do
pending("review behaviour when being passed undef as #{undef_value.inspect}") if undef_value == ''
- pending("review behaviour when being passed undef as #{undef_value.inspect}") if undef_value == nil
+ pending("review behaviour when being passed undef as #{undef_value.inspect}") if undef_value == :undef && is_puppet_6
end
- it { is_expected.to run.with_params({'key' => undef_value}).and_return({}) }
- it { is_expected.to run \
- .with_params({'key1' => 'value1', 'undef_key' => undef_value, 'key2' => 'value2'}) \
- .and_return({'key1' => 'value1', 'key2' => 'value2'})
+ it { is_expected.to run.with_params('key' => undef_value).and_return({}) }
+ it {
+ is_expected.to run \
+ .with_params('key1' => 'value1', 'undef_key' => undef_value, 'key2' => 'value2') \
+ .and_return('key1' => 'value1', 'key2' => 'value2')
}
end
- it "should leave the original argument intact" do
+ it 'leaves the original argument intact' do
argument = { 'key1' => 'value1', 'key2' => undef_value }
original = argument.dup
- result = subject.call([argument,2])
+ _result = subject.execute(argument, 2)
expect(argument).to eq(original)
end
end
- it { is_expected.to run.with_params({'key' => 'undef'}).and_return({'key' => 'undef'}) }
+ it { is_expected.to run.with_params('key' => 'undef').and_return('key' => 'undef') }
end
end