stop using virtual resources for ferm::rule

[mirror/dsa-puppet.git] / modules / puppetmaster / manifests / init.pp

diff --git a/modules/puppetmaster/manifests/init.pp b/modules/puppetmaster/manifests/init.pp
index 08b400f..7cb923c 100644 (file)
--- a/modules/puppetmaster/manifests/init.pp
+++ b/modules/puppetmaster/manifests/init.pp
@@ -10,11 +10,11 @@ class puppetmaster {
                source => 'puppet:///modules/puppetmaster/puppetdb.conf'
        }
 
-       @ferm::rule { 'dsa-puppet':
+       ferm::rule { 'dsa-puppet':
                description     => 'Allow puppet access',
                rule            => '&SERVICE_RANGE(tcp, 8140, $HOST_DEBIAN_V4)'
        }
-       @ferm::rule { 'dsa-puppet-v6':
+       ferm::rule { 'dsa-puppet-v6':
                domain          => 'ip6',
                description     => 'Allow puppet access',
                rule            => '&SERVICE_RANGE(tcp, 8140, $HOST_DEBIAN_V6)'
@@ -27,11 +27,13 @@ class puppetmaster {
        }
        Concat::Fragment <<| tag == "onionbalance-services.yaml" |>>
 
-       file { '/etc/cron.d/puppet-update-fastly-ips':
-               source => 'puppet:///modules/puppetmaster/update-fastly-ips.cron'
-       }
-       file { '/etc/cron.d/update-fastly-ips':
-               ensure => absent,
+       file { '/etc/cron.d/puppet-update-fastly-ips': ensure => absent, }
+       file { '/etc/cron.d/update-fastly-ips': ensure => absent, }
+       concat::fragment { 'dsa-puppet-stuff---fastly-ips':
+               target => '/etc/cron.d/dsa-puppet-stuff',
+               content  => @(EOF)
+                       @daily  root    /usr/local/bin/update-fastly-ips /srv/puppet.debian.org/puppet-facts/fastly_ranges.yaml
+                       | EOF
        }
        file { '/usr/local/bin/update-fastly-ips':
                source => 'puppet:///modules/puppetmaster/update-fastly-ips.sh',