munin class cleanup

[mirror/dsa-puppet.git] / modules / munin / manifests / conf.pp

diff --git a/modules/munin/manifests/conf.pp b/modules/munin/manifests/conf.pp
index 5413c43..ad5026c 100644 (file)
--- a/modules/munin/manifests/conf.pp
+++ b/modules/munin/manifests/conf.pp
@@ -1,34 +1,19 @@
+# a conf.d snippet
+# @param ensure check enabled/disabled
+# @param content content to put into plugon-conf.d/<name>
+# @param source file to put into plugon-conf.d/<name>
 define munin::conf (
-       $ensure=present,
-       $content=false,
-       $source=false
+  Enum['present','absent'] $ensure = 'present',
+  Optional[String] $content = undef,
+  Optional[String] $source = undef,
 ) {
+  include munin
 
-       include munin
-
-       case $ensure {
-               present: {
-                       if ! ($source or $content) {
-                               fail ( "No configuration found for ${name}" )
-                       }
-               }
-               absent:  {}
-               default: { fail ( "Unknown ensure value: '$ensure'" ) }
-       }
-
-       if $source {
-               file { "/etc/munin/plugin-conf.d/${name}":
-                       ensure  => $ensure,
-                       source  => $source,
-                       require => Package['munin-node'],
-                       notify  => Service['munin-node'],
-               }
-       } elsif $content {
-               file { "/etc/munin/plugin-conf.d/${name}":
-                       ensure  => $ensure,
-                       content => $content,
-                       require => Package['munin-node'],
-                       notify  => Service['munin-node'],
-               }
-       }
+  file { "/etc/munin/plugin-conf.d/${name}":
+    ensure  => $ensure,
+    source  => $source,
+    content => $content,
+    require => Package['munin-node'],
+    notify  => Service['munin-node'],
+  }
 }