Revert "Since the conditional does not work for default values for params, fall back...

[mirror/dsa-puppet.git] / modules / bacula / manifests / director.pp

diff --git a/modules/bacula/manifests/director.pp b/modules/bacula/manifests/director.pp
index 5f7fba4..dd5395d 100644 (file)
--- a/modules/bacula/manifests/director.pp
+++ b/modules/bacula/manifests/director.pp
@@ -10,9 +10,10 @@
 # @param db_sslca       SSL CA store for DB access
 # @param director_name  bacula name of this dir instance
 # @param director_address  address of this dir instance that other instances should connect to (dns name)
+# @param messages_name   name of the Messages Resource
 class bacula::director(
-  String  $db_address,
-  Integer $db_port,
+  String  $db_address = 'localhost',
+  Integer $db_port = 5432,
   String  $db_name = 'bacula',
   String  $db_user = 'bacula',
   String  $db_password = hkdf('/etc/puppet/secret', "bacula-db-${::hostname}"),
@@ -21,6 +22,7 @@ class bacula::director(
   Optional[String] $db_sslca = undef,
   String $director_name = "${::fqdn}-dir",
   Stdlib::Host $director_address = $::fqdn,
+  String $messages_name = "Msg-${::fqdn}",
 ) inherits bacula {
 
   # used by e.g. bconsole
@@ -34,12 +36,14 @@ class bacula::director(
     tag              => 'bacula::to-storage',
     director_name    => $director_name,
     director_address => $director_address,
+    messages_name    => $messages_name,
   }
   # let FDs know we exist
   @@bacula::client::director{ $::fqdn:
     tag              => "bacula::to-fd::${director_address}",
     director_name    => $director_name,
     director_address => $director_address,
+    messages_name    => $messages_name,
   }
 
   ensure_packages ( [
@@ -59,7 +63,7 @@ class bacula::director(
   dsa_systemd::override { 'bacula-director':
     content => @(EOT)
       [Unit]
-      After=unbound.service
+      After=network-online.target unbound.service
       | EOT
   }
 
@@ -95,8 +99,8 @@ class bacula::director(
     notify  => Exec['bacula-director reload']
   }
 
-  Bacula::Director::Client             <<| tag == "bacula::to-director::${::fqdn}" |>>
   Bacula::Director::Client_from_storage<<| tag == "bacula::to-director::${::fqdn}" |>>
+  Bacula::Director::Client             <<| tag == "bacula::to-director::${::fqdn}" |>>
 
   package { 'bacula-console':
     ensure => installed;
@@ -144,11 +148,7 @@ class bacula::director(
   }
 
   concat { $bacula::bacula_dsa_client_list:
-  }
-  concat::fragment { 'bacula-dsa-client-list::header' :
-    target  => $bacula::bacula_dsa_client_list,
-    content => '',
-    order   => '00',
+    ensure_newline => true,
   }
   Concat::Fragment <<| tag == $bacula::tag_bacula_dsa_client_list |>>