From 81d4f79a7431c4061147f3ed1c1c17c2d38ed4eb Mon Sep 17 00:00:00 2001
From: Peter Palfrader <peter@palfrader.org>
Date: Mon, 2 Aug 2010 20:23:53 +0000
Subject: [PATCH] Let private generation use Account class

---
 UDLdap.py   |  3 +++
 ud-generate | 10 ++++------
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/UDLdap.py b/UDLdap.py
index 9f8a0fd..74313b2 100644
--- a/UDLdap.py
+++ b/UDLdap.py
@@ -66,6 +66,9 @@ class Account:
     def numkeys(self):
         return len(self['keyFingerPrint'])
 
+    def is_active_user(self):
+        return self['accountStatus'] == 'active' and self.numkeys() != 0
+
     def latitude_dec(self, anonymized=False):
         return userdir_ldap.DecDegree(self['latitude'], anonymized)
     def longitude_dec(self, anonymized=False):
diff --git a/ud-generate b/ud-generate
index 303f9f5..1a40f67 100755
--- a/ud-generate
+++ b/ud-generate
@@ -608,15 +608,13 @@ def GenPrivate(File):
      
       # Write out the position for each user
       for x in DebianDDUsers:
-         if x[1].has_key("privateSub") == 0:
+         a = UDLdap.Account(x[0], x[1])
+         if not a.is_active_user():
             continue
-     
-         # If the account has no PGP key, do not write it
-         if x[1].has_key("keyFingerPrint") == 0:
+         if not 'privateSub' in a:
             continue
-     
          try:
-            Line = "%s"%(GetAttr(x, "privateSub"))
+            Line = "%s"%(a['privateSub'])
             Line = Sanitize(Line) + "\n"
             F.write(Line)
          except:
-- 
2.20.1