From: Helmut Grohne <helmut@subdivi.de>
Date: Sat, 23 Jan 2010 16:20:12 +0000 (+0100)
Subject: do not accept invalid allowed_hosts for ssh keys
X-Git-Tag: userdir-ldap-0.3.76~2
X-Git-Url: https://git.adam-barratt.org.uk/?p=mirror%2Fuserdir-ldap.git;a=commitdiff_plain;h=82aef85537e4199e9db0bf2fcec7db2137561795

do not accept invalid allowed_hosts for ssh keys

Check them against a list ValidHostNames that is generated during
startup.
---

diff --git a/ud-mailgate b/ud-mailgate
index 283ee22..65955f6 100755
--- a/ud-mailgate
+++ b/ud-mailgate
@@ -35,6 +35,7 @@ mailWhitelist = {}
 SeenList = {}
 DNS = {}
 SudoPasswd = {}
+ValidHostNames = [] # will be initialized in later
 
 SSHFingerprint = re.compile('^(\d+) ([0-9a-f\:]{47}) (.+)$')
 SSHRSA1Match = re.compile('^^(.* )?\d+ \d+ \d+')
@@ -293,6 +294,8 @@ def DoSSH(Str, Attrs, badkeys, uid):
             return "empty machine specification for ssh key"
          if not machine_regex.match(m):
             return "machine specification for ssh key contains invalid characters"
+         if m not in ValidHostNames:
+            return "unknown machine used in allowed_hosts stanza for ssh keys"
 
    (fd, path) = tempfile.mkstemp(".pub", "sshkeytry", "/tmp")
    f = open(path, "w")
@@ -772,6 +775,14 @@ try:
    Date = time.strftime("%a, %d %b %Y %H:%M:%S +0000",time.gmtime(time.time()));
    Reply = "To: %s\nReply-To: %s\nDate: %s\n" % (Sender,ReplyTo,Date);
 
+   global ValidHostNames
+   Res = l.search_s(HostBaseDn, ldap.SCOPE_SUBTREE, '(objectClass=debianServer)', ['hostname'] )
+   # Res is a list of tuples.
+   # The tuples contain a dn (str) and a dictionary.
+   # The dictionaries map the key "hostname" to a list.
+   # These lists contain a single hostname (str).
+   ValidHostNames = reduce(lambda a,b: a+b, [value.get("hostname", []) for (dn, value) in Res], [])
+
    # Dispatch
    if sys.argv[1] == "ping":
       Reply = HandlePing(Reply,Attrs[0],Res[2]);