From: James Clarke Date: Sat, 6 Apr 2019 21:19:58 +0000 (+0000) Subject: ud-mailgate: Assign value before check and drop semicolon X-Git-Url: https://git.adam-barratt.org.uk/?p=mirror%2Fuserdir-ldap.git;a=commitdiff_plain;h=1315e069f61f849e597587489bed21173ef812be ud-mailgate: Assign value before check and drop semicolon --- diff --git a/ud-mailgate b/ud-mailgate index 02693b6..32985d1 100755 --- a/ud-mailgate +++ b/ud-mailgate @@ -192,11 +192,10 @@ def DoArbChange(Str, Attrs): if attrName not in ArbChanges: return None - if re.match(ArbChanges[attrName], G[1]) is None: + value = G[1] + if re.match(ArbChanges[attrName], value) is None: raise UDFormatError("Item does not match the required format" + ArbChanges[attrName]) - value = G[1]; - Attrs.append((ldap.MOD_REPLACE, attrName, value)) return "Changed entry %s to %s" % (attrName, value)