From 18f26a9ca182f25cbdfc4c1532e2d34898295e92 Mon Sep 17 00:00:00 2001
From: Peter Palfrader <peter@palfrader.org>
Date: Sun, 22 Sep 2019 12:51:28 +0200
Subject: [PATCH] historical_master -> hiera role

---
 data/common.yaml                             |  3 ---
 data/nodes/sibelius.debian.org.yaml          |  2 ++
 modules/roles/manifests/historical_mirror.pp | 11 ++++++-----
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/data/common.yaml b/data/common.yaml
index 1efdd7630..fd6328b35 100644
--- a/data/common.yaml
+++ b/data/common.yaml
@@ -125,9 +125,6 @@ roles:
         - '[2a02:16a8:dc41:100::232]:80'
       fastly-backend: true
       service-hostname: conova.debian.backend.mirrors.debian.org
-  historical_master:
-    # XXX - used by ferm templates/defs.conf.erb
-    - sibelius.debian.org
   historical_mirror:
     # XXX used also in ferm me.conf.erb
     - gretchaninov.debian.org
diff --git a/data/nodes/sibelius.debian.org.yaml b/data/nodes/sibelius.debian.org.yaml
index 014297365..bf38f67fa 100644
--- a/data/nodes/sibelius.debian.org.yaml
+++ b/data/nodes/sibelius.debian.org.yaml
@@ -1,3 +1,5 @@
 ---
 classes:
   - roles::historical_master
+
+roles::historical_mirror::sslname: archive-master.debian.org
diff --git a/modules/roles/manifests/historical_mirror.pp b/modules/roles/manifests/historical_mirror.pp
index 4ef3af0da..101ecaef6 100644
--- a/modules/roles/manifests/historical_mirror.pp
+++ b/modules/roles/manifests/historical_mirror.pp
@@ -1,4 +1,8 @@
-class roles::historical_mirror {
+# a mirror for archive.debian.org
+# @param sslname provide rsync via ssl as well
+class roles::historical_mirror(
+  Optional[String] $sslname = undef,
+){
   include roles::archvsync_base
   include apache2::expires
 
@@ -22,14 +26,11 @@ class roles::historical_mirror {
     content => template('roles/apache-archive.debian.org.erb'),
   }
 
-  if has_role('historical_master') {
-    $sslname = 'archive-master.debian.org'
+  if $sslname {
     ssl::service { $sslname:
       key      => true,
       tlsaport => [],
     }
-  } else {
-    $sslname = undef
   }
 
   rsync::site { 'archive':
-- 
2.20.1