From: Peter Palfrader <peter@palfrader.org>
Date: Mon, 21 Oct 2019 09:30:04 +0000 (+0200)
Subject: Clean up and document apache2::module
X-Git-Url: https://git.adam-barratt.org.uk/?p=mirror%2Fdsa-puppet.git;a=commitdiff_plain;h=53cec647b19bcfa044f9b5752f2095ce4a73d95e

Clean up and document apache2::module
---

diff --git a/modules/apache2/manifests/module.pp b/modules/apache2/manifests/module.pp
index 38623536f..e3cb3c5a1 100644
--- a/modules/apache2/manifests/module.pp
+++ b/modules/apache2/manifests/module.pp
@@ -1,19 +1,24 @@
-define apache2::module ($ensure = present) {
+# Enable an apache module
+#
+# @param ensure  present or absent
+define apache2::module (
+  Enum['present','absent'] $ensure = 'present',
+) {
   case $ensure {
     present: {
       exec { "/usr/sbin/a2enmod ${name}":
         creates => "/etc/apache2/mods-enabled/${name}.load",
         require => Package['apache2'],
-        notify  => Service['apache2']
+        notify  => Service['apache2'],
       }
     }
     absent: {
       exec { "/usr/sbin/a2dismod ${name}":
         onlyif  => "test -L /etc/apache2/mods-enabled/${name}.load",
         require => Package['apache2'],
-        notify  => Service['apache2']
+        notify  => Service['apache2'],
       }
     }
-    default: { fail ( "Unknown ensure value: '$ensure'" ) }
+    default: { fail ( "Unknown ensure value: ${ensure}" ) }
   }
 }