From: Peter Palfrader <peter@palfrader.org>
Date: Wed, 25 Sep 2019 20:27:38 +0000 (+0200)
Subject: simplify email_error default logic
X-Git-Url: https://git.adam-barratt.org.uk/?p=mirror%2Fdsa-puppet.git;a=commitdiff_plain;h=1cd6b845500d05055a1e291cbdba6fe269254c43

simplify email_error default logic

(by anarcat)
---

diff --git a/modules/bacula/manifests/init.pp b/modules/bacula/manifests/init.pp
index cf83a2689..02cf50615 100644
--- a/modules/bacula/manifests/init.pp
+++ b/modules/bacula/manifests/init.pp
@@ -20,7 +20,8 @@ class bacula (
   String $ssl_server_key,
 
   Optional[String] $email_all = undef,
-  String $email_error                          = $email_all != undef ? { true => $email_all, default => 'root@localhost' },
+  # default to all if defined, otherwise default to 'root' to enforce error delivery
+  String $email_error                          = $email_all ? { undef => 'root', default => $email_all },
   String $email_operator                       = $email_error,
   String $email_daemon                         = $email_error,
   Array[Stdlib::IP::Address] $public_addresses = $base::public_addresses,