From 6d1a430423744a13a6393ca32fa59c5eeaddbaf0 Mon Sep 17 00:00:00 2001 From: Peter Palfrader Date: Thu, 25 Oct 2018 09:48:16 +0200 Subject: [PATCH] dsa-check-zone-rrsig-expiration-many: fix use of uninitialized value in numeric gt (>) We have a state count array, and we assign each state (ok, warn, etc.) a nagios error code. one of the states we use internally is "unsigned", which is not an error but did not have an integer exit code. Give it 0 now. --- dsa-nagios-checks/checks/dsa-check-zone-rrsig-expiration-many | 1 + dsa-nagios-checks/debian/changelog | 2 ++ 2 files changed, 3 insertions(+) diff --git a/dsa-nagios-checks/checks/dsa-check-zone-rrsig-expiration-many b/dsa-nagios-checks/checks/dsa-check-zone-rrsig-expiration-many index ec99484..674dd1c 100755 --- a/dsa-nagios-checks/checks/dsa-check-zone-rrsig-expiration-many +++ b/dsa-nagios-checks/checks/dsa-check-zone-rrsig-expiration-many @@ -190,6 +190,7 @@ my %state_mapping = ( 'unknown' => 255, 'critical' => 2, 'warn' => 1, + 'unsigned' => 0, 'ok' => 0 ); for my $state (@$states) { diff --git a/dsa-nagios-checks/debian/changelog b/dsa-nagios-checks/debian/changelog index c5d80fe..4237d0e 100644 --- a/dsa-nagios-checks/debian/changelog +++ b/dsa-nagios-checks/debian/changelog @@ -2,6 +2,8 @@ dsa-nagios-checks (117) UNRELEASED; urgency=medium * dsa-check-hpssacli: add --ignore-cache * add: dsa-check-unbound-anchors + * dsa-check-zone-rrsig-expiration-many: fix use of uninitialized value + with unsigned zones. -- Peter Palfrader Sun, 11 Mar 2018 09:06:13 +0100 -- 2.20.1