From 31cc527d395038046cf965a79fc3b9ea9aed6160 Mon Sep 17 00:00:00 2001
From: Stephen Gran <steve@lobefin.net>
Date: Sat, 20 Feb 2010 21:07:54 +0000
Subject: [PATCH] what can possibly go wrong

Signed-off-by: Stephen Gran <steve@lobefin.net>
---
 manifests/site.pp              |  3 ++-
 modules/ferm/manifests/init.pp | 43 ++++----------------------------
 modules/ferm/manifests/real.pp | 45 ++++++++++++++++++++++++++++++++++
 3 files changed, 52 insertions(+), 39 deletions(-)
 create mode 100644 modules/ferm/manifests/real.pp

diff --git a/manifests/site.pp b/manifests/site.pp
index 1c719fe7f..fb85a46d4 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -21,6 +21,7 @@ node default {
 
     $mxinfo   = allnodeinfo("mXRecord")
 
+    include ferm
     include munin-node
     include sudo
     include ssh
@@ -80,7 +81,7 @@ node default {
     }
 
     case $hostname {
-        logtest01: { include ferm }
+        logtest01: { include ferm::real }
     }
     case $hostname {
         geo1,geo2,geo3: { include named::geodns }
diff --git a/modules/ferm/manifests/init.pp b/modules/ferm/manifests/init.pp
index 55f619e95..c07449fb1 100644
--- a/modules/ferm/manifests/init.pp
+++ b/modules/ferm/manifests/init.pp
@@ -10,49 +10,16 @@ class ferm {
 	        }
 	}
 
-        package { ferm: ensure => installed }
-
         file { 
+                "/etc/ferm": 
+                        ensure => directory;
                 "/etc/ferm/dsa.d": 
-                        ensure => directory,
-                        require => Package["ferm"];
-                "/etc/ferm/conf.d": 
-                        ensure => directory,
-                        require => Package["ferm"];
-                "/etc/ferm/ferm.conf":
-                        source  => "puppet:///ferm/ferm.conf",
-                        require => Package["ferm"],
-                        notify  => Exec["ferm restart"];
-                "/etc/ferm/conf.d/me.conf":
-                        content => template("ferm/me.conf.erb"),
-                        require => Package["ferm"],
-                        notify  => Exec["ferm restart"];
-                "/etc/ferm/conf.d/defs.conf":
-                        source  => "puppet:///ferm/defs.conf",
-                        require => Package["ferm"],
-                        notify  => Exec["ferm restart"];
-        }
-
-        ferm::rule { "dsa-ssh":
-                description     => "Allow SSH from DSA",
-                rule            => "proto tcp mod state state (NEW) dport (ssh) @subchain 'ssh' { saddr (\$SSH_SOURCES) ACCEPT; }"
-        }
-        ferm::rule { "dsa-ssh-v6":
-                description     => "Allow SSH from DSA",
-                domain          => "ip6",
-                rule            => "proto tcp mod state state (NEW) dport (ssh) @subchain 'ssh' { saddr (\$SSH_V6_SOURCES) ACCEPT; }"
-        }
-        ferm::rule { "dsa-munin":
-                description     => "Allow munin from munin master",
-                rule            => "proto tcp mod state state (NEW) dport (munin) @subchain 'munin' { saddr (\$HOST_MUNIN) ACCEPT; }"
-        }
-        ferm::rule { "dsa-nagios":
-                description     => "Allow nrpe from nagios master",
-                rule            => "proto tcp mod state state (NEW) dport (5666) @subchain 'nagios' { saddr (\$HOST_NAGIOS) ACCEPT; }"
+                        ensure => directory;
         }
 
         exec { "ferm restart":
-                path        => "/etc/init.d:/usr/bin:/usr/sbin:/bin:/sbin",
+                command     => "/bin/true",
                 refreshonly => true,
         }
+
 }
diff --git a/modules/ferm/manifests/real.pp b/modules/ferm/manifests/real.pp
new file mode 100644
index 000000000..6ad7bccd4
--- /dev/null
+++ b/modules/ferm/manifests/real.pp
@@ -0,0 +1,45 @@
+class ferm::real {
+
+        package { ferm: ensure => installed }
+
+        file { 
+                "/etc/ferm/conf.d": 
+                        ensure => directory,
+                        require => Package["ferm"];
+                "/etc/ferm/ferm.conf":
+                        source  => "puppet:///ferm/ferm.conf",
+                        require => Package["ferm"],
+                        notify  => Exec["ferm restart"];
+                "/etc/ferm/conf.d/me.conf":
+                        content => template("ferm/me.conf.erb"),
+                        require => Package["ferm"],
+                        notify  => Exec["ferm restart"];
+                "/etc/ferm/conf.d/defs.conf":
+                        source  => "puppet:///ferm/defs.conf",
+                        require => Package["ferm"],
+                        notify  => Exec["ferm restart"];
+        }
+
+        ferm::rule { "dsa-ssh":
+                description     => "Allow SSH from DSA",
+                rule            => "proto tcp mod state state (NEW) dport (ssh) @subchain 'ssh' { saddr (\$SSH_SOURCES) ACCEPT; }"
+        }
+        ferm::rule { "dsa-ssh-v6":
+                description     => "Allow SSH from DSA",
+                domain          => "ip6",
+                rule            => "proto tcp mod state state (NEW) dport (ssh) @subchain 'ssh' { saddr (\$SSH_V6_SOURCES) ACCEPT; }"
+        }
+        ferm::rule { "dsa-munin":
+                description     => "Allow munin from munin master",
+                rule            => "proto tcp mod state state (NEW) dport (munin) @subchain 'munin' { saddr (\$HOST_MUNIN) ACCEPT; }"
+        }
+        ferm::rule { "dsa-nagios":
+                description     => "Allow nrpe from nagios master",
+                rule            => "proto tcp mod state state (NEW) dport (5666) @subchain 'nagios' { saddr (\$HOST_NAGIOS) ACCEPT; }"
+        }
+
+        exec { "ferm restart":
+                path        => "/etc/init.d:/usr/bin:/usr/sbin:/bin:/sbin",
+                refreshonly => true,
+        }
+}
-- 
2.20.1