From: Peter Palfrader <peter@palfrader.org>
Date: Wed, 2 Mar 2011 11:33:16 +0000 (+0100)
Subject: Revert "and merge mxinfo into allnodeinfo"
X-Git-Url: https://git.adam-barratt.org.uk/?a=commitdiff_plain;h=96055f5e2bbc5c9185f1b194a039df68c9549af2;p=mirror%2Fdsa-puppet.git

Revert "and merge mxinfo into allnodeinfo"

This reverts commit d57f90694b908a8a5a326fea7597710104f9fb29.

Currently we would only fetch hosts that have all of the attributes in
question.
---

diff --git a/manifests/site.pp b/manifests/site.pp
index 394cf8fa7..5dfeef0a8 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -17,7 +17,8 @@ node default {
     $localinfo = yamlinfo('*', "/etc/puppet/modules/debian-org/misc/local.yaml")
     $nodeinfo  = nodeinfo($fqdn, "/etc/puppet/modules/debian-org/misc/local.yaml")
     $hosterinfo = whohosts($nodeinfo, "/etc/puppet/modules/debian-org/misc/hoster.yaml")
-    $allnodeinfo = allnodeinfo("sshRSAHostKey", "ipHostNumber", "purpose", "mXRecord")
+    $allnodeinfo = allnodeinfo("sshRSAHostKey", "ipHostNumber", "purpose")
+    $mxinfo    = allnodeinfo("mXRecord")
     notice("hoster for ${fqdn} is ${hosterinfo}")
 
     include munin-node
diff --git a/modules/exim/templates/manualroute.erb b/modules/exim/templates/manualroute.erb
index 40062d8dc..ce22a342b 100644
--- a/modules/exim/templates/manualroute.erb
+++ b/modules/exim/templates/manualroute.erb
@@ -18,9 +18,8 @@ if nodeinfo['mailrelay']
 end
 
 mxregex = Regexp.new('^\d+\s+(.*)\.$')
-allnodeinfo.keys.sort.each do |host|
-  next unless allnodeinfo[host]['mXRecord']
-  allnodeinfo[host]['mXRecord'].each do |mx|
+mxinfo.keys.sort.each do |host|
+  mxinfo[host]['mXRecord'].each do |mx|
     mxmatch = mxregex.match(mx)
     if mxmatches.include?(mxmatch[1])
       route = host + ":\t\t" + host