From: Peter Palfrader <peter@palfrader.org>
Date: Sat, 28 Sep 2019 18:48:16 +0000 (+0200)
Subject: Try something else to get a default for postgres::backup_cluster::db_backup_role
X-Git-Url: https://git.adam-barratt.org.uk/?a=commitdiff_plain;h=7af16f703228c0239f4adae38d04ef7612b611c3;p=mirror%2Fdsa-puppet.git

Try something else to get a default for postgres::backup_cluster::db_backup_role
---

diff --git a/data/common.yaml b/data/common.yaml
index a4f5e826b..8e1f05c9f 100644
--- a/data/common.yaml
+++ b/data/common.yaml
@@ -30,7 +30,7 @@ roles::dns_primary::allow_access:
   - '194.146.105.25'
   - '2a01:3f0:0:27::24'
   - '2a01:3f0:0:28::25'
-postgres::backup_cluster::db_backup_role: debian-backup
+postgres::db_backup_role: 'debian-backup'
 # bacula
 #
 bacula::email_all: 'bacula-reports@admin.debian.org'
diff --git a/modules/postgres/manifests/backup_cluster.pp b/modules/postgres/manifests/backup_cluster.pp
index bb61e9356..98c77bc8f 100644
--- a/modules/postgres/manifests/backup_cluster.pp
+++ b/modules/postgres/manifests/backup_cluster.pp
@@ -1,7 +1,15 @@
+# Backup this cluster
 #
+# @param pg_version      pg version of the cluster
+# @param pg_backup_role  replication role username
+# @param pg_cluster      cluster name
+# @param pg_port         port of the postgres cluster
+# @param db_backup_role_password     password of the replication role
+# @param do_role         create the role (requires setup with postgresql::server)
+# @param do_hba          update pg_hba (requires setup with postgresql::server)
 define postgres::backup_cluster(
   String $pg_version,
-  String $db_backup_role,
+  String $db_backup_role = lookup('postgres::backup_cluster::db_backup_role'),
   String $pg_cluster = 'main',
   Integer $pg_port = 5432,
   String $db_backup_role_password = hkdf('/etc/puppet/secret', "postgresql-${::hostname}-${$pg_cluster}-${pg_port}-backup_role}"),