From: Peter Palfrader <peter@palfrader.org>
Date: Sun, 15 Sep 2019 14:10:28 +0000 (+0200)
Subject: cdimage_search -> hiera role; explicitly include apache2
X-Git-Url: https://git.adam-barratt.org.uk/?a=commitdiff_plain;h=1ace4975a6abe19f1209bcd1958002227f6abd8e;p=mirror%2Fdsa-puppet.git

cdimage_search -> hiera role; explicitly include apache2
---

diff --git a/hieradata/common.yaml b/hieradata/common.yaml
index ca45b2db3..d371eefd8 100644
--- a/hieradata/common.yaml
+++ b/hieradata/common.yaml
@@ -231,8 +231,6 @@ roles:
   bgp:
     - mirror-accumu.debian.org
     - mirror-skroutz.debian.org
-  cdimage-search:
-    - cgi-grnet-01.debian.org
   apache_prefork:
     # php needs this
     - quantz.debian.org
diff --git a/hieradata/nodes/cgi-grnet-01.debian.org.yaml b/hieradata/nodes/cgi-grnet-01.debian.org.yaml
index 8e45ae1e9..add01d6a8 100644
--- a/hieradata/nodes/cgi-grnet-01.debian.org.yaml
+++ b/hieradata/nodes/cgi-grnet-01.debian.org.yaml
@@ -1,6 +1,7 @@
 ---
 classes:
   - roles::anonscm
+  - roles::cdimage_search
   - roles::dgit_browse
   - roles::dgit_git
   - roles::search_frontend
diff --git a/modules/roles/manifests/cdimage_search.pp b/modules/roles/manifests/cdimage_search.pp
index 9c1859ceb..69269eef4 100644
--- a/modules/roles/manifests/cdimage_search.pp
+++ b/modules/roles/manifests/cdimage_search.pp
@@ -1,14 +1,15 @@
 class roles::cdimage_search {
-	include apache2::proxy_http
-	include apache2::ssl
+  include apache2
+  include apache2::proxy_http
+  include apache2::ssl
 
-	package { 'debian.org-cdimage-search.debian.org': ensure => installed, }
+  package { 'debian.org-cdimage-search.debian.org': ensure => installed, }
 
-	ssl::service { 'cdimage-search.debian.org': notify  => Exec['service apache2 reload'], key => true, }
-	apache2::site { '010-cdimage-search.debian.org':
-		site   => 'cdimage-search.debian.org',
-		content => template('roles/apache-cdimage-search.debian.org.conf.erb')
-	}
+  ssl::service { 'cdimage-search.debian.org': notify  => Exec['service apache2 reload'], key => true, }
+  apache2::site { '010-cdimage-search.debian.org':
+    site    => 'cdimage-search.debian.org',
+    content => template('roles/apache-cdimage-search.debian.org.conf.erb')
+  }
 
-	onion::service { 'cdimage-search.debian.org': port => 80, target_address => 'cdimage-search.debian.org', target_port => 80, direct => true }
+  onion::service { 'cdimage-search.debian.org': port => 80, target_address => 'cdimage-search.debian.org', target_port => 80, direct => true }
 }
diff --git a/modules/roles/manifests/init.pp b/modules/roles/manifests/init.pp
index 63ec89d9b..25e6bbd6d 100644
--- a/modules/roles/manifests/init.pp
+++ b/modules/roles/manifests/init.pp
@@ -191,9 +191,6 @@ class roles {
 	if has_role('bgp') {
 		include roles::bgp
 	}
-	if has_role('cdimage-search') {
-		include roles::cdimage_search
-	}
 
 	if has_role('postgresql_server') {
 		include postgres::backup_source