X-Git-Url: https://git.adam-barratt.org.uk/?a=blobdiff_plain;f=update.cgi;h=36631697b96dc5b7fa50aef740b57666034fa39e;hb=d7b018a2e8aa309a6fe581c331cbe1d475a3ccef;hp=4db9464cd648ad1ef4520d22d728f92973394824;hpb=86db90437e60869cae6c0a7689e63d277991c52f;p=mirror%2Fuserdir-ldap-cgi.git diff --git a/update.cgi b/update.cgi index 4db9464..3663169 100755 --- a/update.cgi +++ b/update.cgi @@ -13,6 +13,7 @@ use Digest::HMAC_SHA1 qw(hmac_sha1_hex); use Util; use English; use URI::Escape; +use Crypt::PasswdMD5; use Net::LDAP qw(LDAP_SUCCESS LDAP_PROTOCOL_ERROR); my %config = &Util::ReadConfigFile; @@ -41,7 +42,7 @@ sub DieHandler { $ldap->unbind if (defined($ldap)); } -$SIG{__DIE__} = \&DieHandler; +#$SIG{__DIE__} = \&DieHandler; $ldap = Net::LDAP->new($config{ldaphost}); &Util::UpgradeConnection($ldap) unless $config{usessl} eq 'False'; @@ -206,7 +207,7 @@ if (!($query->param('doupdate'))) { # Actually update stuff... - my ($newpassword, $newstaddress, $newwebpassword); + my ($newpassword, $newstaddress, $newwebpassword, $newvoippassword); # Good god, why would we want to do that here? it breaks password setting # etc, and it doesn't prevent people from setting eveil stuff in ldap @@ -239,19 +240,34 @@ if (!($query->param('doupdate'))) { if ($query->param('newwebpass') && $query->param('newwebpassvrfy')) { if ($query->param('newwebpass') ne $query->param('newwebpassvrfy')) { # passwords don't match... - &Util::HTMLError("The passwords you specified do not match. Please go back and try again."); + &Util::HTMLError("The web-passwords you specified do not match. Please go back and try again."); } my ($r, $msg) = &Util::checkPasswordQuality($query->param('newwebpass'), undef, [@ldapinfo_for_pwcheck]); if ($r) { - &Util::HTMLError("Password check failed: $msg. Please go back and try again."); + &Util::HTMLError("Password check failed for web-password: $msg. Please go back and try again."); } # create a md5 crypted password - $newwebpassword = crypt($query->param('newwebpass'), &Util::CreateCryptSalt(1)); + $newwebpassword = apache_md5_crypt($query->param('newwebpass'), &Util::CreateCryptSalt(1, 1)); &Util::LDAPUpdate($ldap, $editdn, 'webPassword', $newwebpassword); } + if ($query->param('newvoippass') && $query->param('newvoippassvrfy')) { + if ($query->param('newvoippass') ne $query->param('newvoippassvrfy')) { + # passwords don't match... + &Util::HTMLError("The voip-passwords you specified do not match. Please go back and try again."); + } + + my ($r, $msg) = &Util::checkPasswordQuality($query->param('newvoippass'), undef, [@ldapinfo_for_pwcheck]); + if ($r) { + &Util::HTMLError("Password check failed for voip-password: $msg. Please go back and try again."); + } + # create a md5 crypted password + $newvoippassword = '{crypt}'.crypt($query->param('newpass'), &Util::CreateCryptSalt(1)); + + &Util::LDAPUpdate($ldap, $editdn, 'voipPassword', $newvoippassword); + } $newstaddress = $query->param('staddress'); $newstaddress =~ s/\n/\$/m;