X-Git-Url: https://git.adam-barratt.org.uk/?a=blobdiff_plain;f=modules%2Fxinetd%2Fmanifests%2Fservice.pp;h=c348579fab704e1d2d59f6ab7ad8f4743f121799;hb=1e21bed9a8238b5bf8e9f348993614ee5dc60a0d;hp=d45e867a2feb7acb505a96c47354136d4f83d3d4;hpb=64497f03874c0bbf33be7fa6287dd769cded0751;p=mirror%2Fdsa-puppet.git

diff --git a/modules/xinetd/manifests/service.pp b/modules/xinetd/manifests/service.pp
index d45e867a2..c348579fa 100644
--- a/modules/xinetd/manifests/service.pp
+++ b/modules/xinetd/manifests/service.pp
@@ -1,13 +1,16 @@
 define xinetd::service (
-	$bind,
 	$id,
 	$server,
-	$port,
+	$service,
+	$port='',
+	$bind='',
+	$type='',
 	$socket_type=stream,
 	$protocol=tcp,
-	$flags=IPv6,
+	$flags='',
 	$wait=no,
 	$user=root,
+	$group='',
 	$server_args='',
 	$nice=10,
 	$instances=100,
@@ -20,19 +23,23 @@ define xinetd::service (
 
 	case $ensure {
 		present,absent,file: {}
-		default: { fail("Invalid ensure for '$title'") }
+		default: { fail("Invalid ensure for '$name'") }
 	}
 
 	if $ferm {
-		@ferm::rule { "dsa-xinetd-${title}":
-			description => "Allow traffic to ${port}",
-			rule        => "&SERVICE(${protocol}, ${port})"
+		$fermport = $port ? {
+			"" => $service,
+			default => $port
+		}
+
+		@ferm::rule { "dsa-xinetd-${name}":
+			description => "Allow traffic to ${service}",
+			rule        => "&SERVICE(${protocol}, ${fermport})"
 		}
 	}
 
-	file { "/etc/xinetd.d/${title}.conf":
+	file { "/etc/xinetd.d/${name}":
 		ensure  => $ensure,
-		noop    => true,
 		content => template('xinetd/service.erb'),
 		notify  => Service['xinetd'],
 		require => Package['xinetd'],