X-Git-Url: https://git.adam-barratt.org.uk/?a=blobdiff_plain;f=modules%2Funbound%2Fmanifests%2Finit.pp;h=3a0eeb34ec8bdac2b009f6ca659221decc963466;hb=814003c1e3dab65aaefb7971bb0380d07c0ddc9a;hp=5261009bbebed1de7b60d06be5192182ce144d7d;hpb=0e7f3f8bafd5509c7aaee25acdfb9e9753ba16ea;p=mirror%2Fdsa-puppet.git

diff --git a/modules/unbound/manifests/init.pp b/modules/unbound/manifests/init.pp
index 5261009bb..3a0eeb34e 100644
--- a/modules/unbound/manifests/init.pp
+++ b/modules/unbound/manifests/init.pp
@@ -9,7 +9,8 @@
 class unbound {
 
 	$is_recursor   = getfromhash($site::nodeinfo, 'misc', 'resolver-recursive')
-	$client_ranges = getfromhash($site::nodeinfo, 'hoster', 'allow_dns_query')
+	$client_ranges = hiera('allow_dns_query')
+	$empty_client_range = empty($client_ranges)
 	$ns            = hiera('nameservers')
 
 	package { 'unbound':
@@ -45,6 +46,14 @@ class unbound {
 		mode    => '0644',
 		source  => 'puppet:///modules/unbound/debian.org.key'
 	}
+	file { '/var/lib/unbound/29.172.in-addr.arpa.key':
+		ensure  => present,
+		replace => false,
+		owner   => unbound,
+		group   => unbound,
+		mode    => '0644',
+		source  => 'puppet:///modules/unbound/29.172.in-addr.arpa.key'
+	}
 	file { '/etc/unbound/unbound.conf':
 		content => template('unbound/unbound.conf.erb'),
 		require => [
@@ -55,16 +64,16 @@ class unbound {
 		notify  => Service['unbound']
 	}
 
-	if ($is_recursor and $client_ranges) {
+	if ($is_recursor and !$empty_client_range) { 
 		@ferm::rule { 'dsa-dns':
 			domain      => 'ip',
 			description => 'Allow nameserver access',
-			rule        => sprintf('&TCP_UDP_SERVICE_RANGE(53, (%s))', join_spc(filter_ipv4(getfromhash($site::nodeinfo, 'hoster', 'allow_dns_query')))),
+			rule        => sprintf('&TCP_UDP_SERVICE_RANGE(53, (%s))', join_spc(filter_ipv4($client_ranges))),
 		}
 		@ferm::rule { 'dsa-dns6':
 			domain      => 'ip6',
 			description => 'Allow nameserver access',
-			rule        => sprintf('&TCP_UDP_SERVICE_RANGE(53, (%s))', join_spc(filter_ipv6(getfromhash($site::nodeinfo, 'hoster', 'allow_dns_query')))),
+			rule        => sprintf('&TCP_UDP_SERVICE_RANGE(53, (%s))', join_spc(filter_ipv6($client_ranges))),
 		}
 	}
 }