X-Git-Url: https://git.adam-barratt.org.uk/?a=blobdiff_plain;f=dsa-nagios-checks%2Fchecks%2Fdsa-check-hpasm;h=e4582833e074bb39ceba1284918faa04a0c4a51b;hb=bd2b672aea916fcf07a158fbd3d09c3aafeb23d1;hp=029fc018923c0e1fdef31d0a9138b816dd2dbcf4;hpb=6e7ea8feaf631aac30b0164dfdf65ffb914d7898;p=mirror%2Fdsa-nagios.git

diff --git a/dsa-nagios-checks/checks/dsa-check-hpasm b/dsa-nagios-checks/checks/dsa-check-hpasm
index 029fc01..e458283 100755
--- a/dsa-nagios-checks/checks/dsa-check-hpasm
+++ b/dsa-nagios-checks/checks/dsa-check-hpasm
@@ -2,11 +2,14 @@
 
 use strict;
 use warnings;
+use English;
+use Getopt::Long;
 
 # check status of various hardware devices (fans, temp, dimms, powersupply)
 # requires hpasmcli
 
 # Copyright (c) 2009 Stephen Gran <steve@lobefin.net>
+# Copyright (c) 2009,2010,2012 Peter Palfrader
 #
 # Permission is hereby granted, free of charge, to any person obtaining
 # a copy of this software and associated documentation files (the
@@ -42,6 +45,28 @@ my %callbacks = (
   'SHOW TEMP'        => \&do_temp,
 );
 
+
+my $params = {};
+
+my $USAGE = "PROGRAM_NAME: Usage: $PROGRAM_NAME [--help] [--ps-no-redundant] [--fan-no-redundant] [--fan-high] [--dimm-na] [--fan-ignore-not-present]\n";
+Getopt::Long::config('bundling');
+if (!GetOptions (
+        '--help'                        => \$params->{'help'},
+        '--ps-no-redundant'             => \$params->{'ps-no-redundant'},
+        '--fan-no-redundant'            => \$params->{'fan-no-redundant'},
+        '--fan-high'                    => \$params->{'fan-high'},
+        '--dimm-na'                     => \$params->{'dimm-na'},
+        '--fan-ignore-not-present'      => \$params->{'fan-ignore-not-present'},
+        )) {
+        die ("$USAGE");
+};
+if ($params->{'help'}) {
+        print "$USAGE";
+        print "Checks hp hardware health.\n";
+        exit (0);
+};
+
+
 my $prompt = "hpasmcli>";
 my $exit_status = 0;
 my $ret = '';
@@ -61,7 +86,8 @@ sub do_dimm {
 
     if ($line =~ /(^\s*$|-----)/) {
       if ($in_block) {
-        if ($status ne 'Ok') {
+        unless (($status eq 'Ok') ||
+                ($params->{'dimm-na'} && $status eq 'N/A')) {
           $message = sprintf("DIMM%d: %s ", $dimm_num, $status);
           $exit_status |= 2;
         }
@@ -119,13 +145,13 @@ sub do_fans {
 
       if ($line[2] ne 'Yes') {
         $message = sprintf("FAN%d: status=%s ", $fan_num, $line[2]);
-        $exit_status |= 2;
+        $exit_status |= 2 unless ($params->{'fan-ignore-not-present'});
       } elsif ($line[3] ne 'NORMAL') {
         $message = sprintf("FAN%d: speed=%s ", $fan_num, $line[3]);
-        $exit_status |= 1;
+        $exit_status |= 1 unless ($line[3] eq 'HIGH' && $params->{'fan-high'});
       } elsif ($line[5] ne 'Yes') {
         $message = sprintf("FAN%d: redundant=%s ",$fan_num, $line[5]);
-        $exit_status |= 1;
+        $exit_status |= 1 unless ($params->{'fan-no-redundant'});
       }
     } elsif ($line =~ /($prompt|^\s*$)/) {
       last;
@@ -176,7 +202,7 @@ sub do_powersupply {
       my $redundant = $1;
       if ($redundant ne 'Yes') {
         $message = sprintf("PS%d not redundant ", $ps_num);
-        $exit_status |= 1;
+        $exit_status |= 1 unless ($params->{'ps-no-redundant'});
       }
     } elsif ($line =~ /($prompt|^\s*$)/) {
       last;
@@ -222,8 +248,8 @@ sub do_temp {
       next if ($threshold eq '-');
       $num_temp++;
 
-      my $off = $threshold - $current_temp;
       if ($current_temp ne '-') {
+        my $off = $threshold - $current_temp;
         if ($off <= 0) {
           $message = sprintf("TEMP zone=%s %sC/%sC ", $zone, $current_temp, $threshold);
           $exit_status |= 2;
@@ -260,7 +286,7 @@ for my $line (@output) {
 }
 
 if ($exit_status & 2) {
-  print "CRTICAL: $ret\n";
+  print "CRITICAL: $ret\n";
   exit 2;
 } elsif ($exit_status & 1) {
   print "WARNING: $ret\n";