X-Git-Url: https://git.adam-barratt.org.uk/?a=blobdiff_plain;f=dsa-nagios-checks%2Fchecks%2Fdsa-check-hpacucli;h=243d45c220afba5044d927042e8af3e41f7ea1ff;hb=4b93c82f0bfb726242324294207abf254694b81e;hp=8f62bb9192c622f345cbfea13079291ed00e57e0;hpb=f036b6784e2b621886176a00e807e4080dd7315a;p=mirror%2Fdsa-nagios.git

diff --git a/dsa-nagios-checks/checks/dsa-check-hpacucli b/dsa-nagios-checks/checks/dsa-check-hpacucli
index 8f62bb9..243d45c 100755
--- a/dsa-nagios-checks/checks/dsa-check-hpacucli
+++ b/dsa-nagios-checks/checks/dsa-check-hpacucli
@@ -64,12 +64,14 @@ sub record($) {
 	};
 }
 
-my $usage = "$PROGRAM_NAME: Usage: $PROGRAM_NAME [--no-battery] [--ignore-transfer-speed=<pd> [--ignore-transfer-speed=<pd> ...]]\n";
+my $usage = "$PROGRAM_NAME: Usage: $PROGRAM_NAME [--no-battery] [--ignore-controller=<regex>] [--no-controller-ok] [--ignore-transfer-speed=<pd> [--ignore-transfer-speed=<pd> ...]]\n";
 my $params;
 Getopt::Long::Configure('bundling');
 if (!GetOptions (
 	'--help'                      => \$params->{'help'},
 	'--no-battery'                => \$params->{'no-battery'},
+	'--no-controller-ok'          => \$params->{'no-controller-ok'},
+	'--ignore-controller=s'       => \$params->{'ignore-controller'},
 	'--ignore-transfer-speed=s@'  => \$params->{'ignore-transfer-speed'},
 	)) {
 	die ($usage);
@@ -85,6 +87,7 @@ my @controllers;
 for (@$ctrlallshow) {
 	chomp;
 	next if /^$/;
+	next if ($params->{'ignore-controller'} && /$params->{'ignore-controller'}/);
 	if (/in Slot ([0-9a-z]+)/) {
 		push @controllers, $1;
 		next;
@@ -93,17 +96,75 @@ for (@$ctrlallshow) {
 };
 
 if (scalar @controllers == 0) {
-	print "UNKNONW: No smartarray controllers found with hpacucli\n";
-	exit $CODE{'UNKNOWN'}
+	if ($params->{'no-controller-ok'}) {
+		print "No smartarray controllers found with hpacucli\n";
+		exit $CODE{'OK'}
+	} else {
+		print "UNKNOWN: No smartarray controllers found with hpacucli\n";
+		exit $CODE{'UNKNOWN'}
+	}
 };
 
 my @resultstr;
 
 for my $slot (sort @controllers) {
-	my $pds = runcmd("controller slot=$slot pd all show");
 	my @drives;
 	my $nodrives = 0;
 	my %status;
+
+	my $ldallshow = runcmd("controller slot=$slot ld all show");
+	my @logicaldrives;
+	for (@$ldallshow) {
+		chomp;
+		next if /^$/;
+		next if (/^\S.*in Slot $slot/);
+		next if /^ *array [A-Z]$/;
+		if (/logicaldrive ([0-9a-z]+)/) {
+			push @logicaldrives, $1;
+			next;
+		} elsif (/^Error: The specified device does not have any logical drives.$/) {
+			$nodrives = 1;
+		} else {
+			die ("Cannot read line '$_' gotten from hpacucli controller slot = $slot logicaldrive all show\n");
+		}
+	};
+
+	# check logicaldrives
+	for my $logicaldrive (sort @logicaldrives) {
+		my $lds = runcmd("controller slot=$slot ld $logicaldrive show");
+		for (@$lds) {
+			chomp;
+			next if /^$/;
+			if (/^ *Parity Initialization Status: (Initialization Completed|Initialization Failed|Rebuilding)$/) {
+				my $status = $1;
+				if ($status eq 'Initialization Completed') {
+					push @{$status{'OK'}}, "Parity LD$logicaldrive";
+				} elsif ($status eq 'Rebuilding') {
+					push @{$status{'Failed'}}, "Parity LD$logicaldrive";
+					record('WARNING');
+				} elsif ($status eq 'Initialization Failed') {
+					push @{$status{'Failed'}}, "Parity LD$logicaldrive";
+					record('CRITICAL');
+				} else {
+					record('UNKNOWN');
+				}
+			}
+		}
+	}
+
+	if (!$nodrives && scalar @logicaldrives == 0) {
+		push @resultstr, "Slot $slot: unexpectedly, found no logical drives in list.";
+		record('UNKNOWN');
+	} elsif ($nodrives && scalar keys %status > 0) {
+		push @resultstr, "Slot $slot: have no logical drives but status results?";
+		record('UNKNOWN');
+		next;
+	} elsif ($nodrives) {
+		push @resultstr, "Slot $slot: no logical drives";
+	};
+
+
+	my $pds = runcmd("controller slot=$slot pd all show");
 	for (@$pds) {
 		chomp;
 		next if /^$/;
@@ -183,7 +244,9 @@ for my $slot (sort @controllers) {
 			};
 		} elsif ($type eq 'SAS' || $type eq 'SAS+') {
 			$key = 'PHY Transfer Rate';
-			if ($value{'PHY Count'} eq '2') {
+			if ($value{'Interface Type'} eq 'SATA') {
+				$expected = [ '1.5Gbps', '3.0Gbps' ];
+			} elsif ($value{'PHY Count'} eq '2') {
 				if (defined($value{'Redundant Path(s)'})) {
 					$expected = [ '3.0GBPS, 3.0GBPS', '6.0GBPS, 6.0GBPS' ];
 				} else {
@@ -208,11 +271,11 @@ for my $slot (sort @controllers) {
 			record('WARNING');
 			push @{$status{'unknown transfer speed'}}, $drive;
 		} elsif (ref($expected) eq 'ARRAY') {
-			if (scalar(grep { $value{$key} eq $_ } @$expected) == 0) {
+			if (scalar(grep { uc($value{$key}) eq uc($_) } @$expected) == 0) {
 				record('WARNING');
 				push @{$status{'bad transfer speed'}}, $drive."(".$value{$key}.")";
 			};
-		} elsif ($value{$key} ne $expected) {
+		} elsif (uc($value{$key}) ne uc($expected)) {
 			record('WARNING');
 			push @{$status{'bad transfer speed'}}, $drive."(".$value{$key}.")";
 		};