X-Git-Url: https://git.adam-barratt.org.uk/?a=blobdiff_plain;f=3rdparty%2Fmodules%2Fstdlib%2Fspec%2Ffunctions%2Fparseyaml_spec.rb;h=62e18a324b98e35d2a7ef752911618b70bc54b8f;hb=30caaa85aed7015ca0d77216bff175eebd917eb7;hp=e5f145ba1cad3742478019aadd74310cc59bc147;hpb=ad88f67c13ae0f1a08936dad643f1e3509ab5f40;p=mirror%2Fdsa-puppet.git

diff --git a/3rdparty/modules/stdlib/spec/functions/parseyaml_spec.rb b/3rdparty/modules/stdlib/spec/functions/parseyaml_spec.rb
old mode 100755
new mode 100644
index e5f145ba1..62e18a324
--- a/3rdparty/modules/stdlib/spec/functions/parseyaml_spec.rb
+++ b/3rdparty/modules/stdlib/spec/functions/parseyaml_spec.rb
@@ -1,24 +1,74 @@
-#! /usr/bin/env ruby -S rspec
 require 'spec_helper'
 
-describe "the parseyaml function" do
-  let(:scope) { PuppetlabsSpec::PuppetInternals.scope }
+describe 'parseyaml' do
+  it 'exists' do
+    is_expected.not_to eq(nil)
+  end
+
+  it 'raises an error if called without any arguments' do
+    is_expected.to run.with_params
+                      .and_raise_error(%r{wrong number of arguments}i)
+  end
+
+  context 'with correct YAML data' do
+    it 'is able to parse a YAML data with a String' do
+      actual_array = ['--- just a string', 'just a string']
+      actual_array.each do |actual|
+        is_expected.to run.with_params(actual).and_return('just a string')
+      end
+    end
+
+    it 'is able to parse YAML data with a Hash' do
+      is_expected.to run.with_params("---\na: '1'\nb: '2'\n")
+                        .and_return('a' => '1', 'b' => '2')
+    end
 
-  it "should exist" do
-    expect(Puppet::Parser::Functions.function("parseyaml")).to eq("function_parseyaml")
+    it 'is able to parse YAML data with an Array' do
+      is_expected.to run.with_params("---\n- a\n- b\n- c\n")
+                        .and_return(['a', 'b', 'c'])
+    end
+
+    it 'is able to parse YAML data with a mixed structure' do
+      is_expected.to run.with_params("---\na: '1'\nb: 2\nc:\n  d:\n  - :a\n  - true\n  - false\n")
+                        .and_return('a' => '1', 'b' => 2, 'c' => { 'd' => [:a, true, false] })
+    end
+
+    it 'is able to parse YAML data with a UTF8 and double byte characters' do
+      is_expected.to run.with_params("---\na: ×\nこれ: 記号\nです:\n  ©:\n  - Á\n  - ß\n")
+                        .and_return('a' => '×', 'これ' => '記号', 'です' => { '©' => ['Á', 'ß'] })
+    end
+
+    it 'does not return the default value if the data was parsed correctly' do
+      is_expected.to run.with_params("---\na: '1'\n", 'default_value')
+                        .and_return('a' => '1')
+    end
   end
 
-  it "should raise a ParseError if there is less than 1 arguments" do
-    expect { scope.function_parseyaml([]) }.to( raise_error(Puppet::ParseError))
+  it 'raises an error with invalid YAML and no default' do
+    is_expected.to run.with_params('["one"')
+                      .and_raise_error(Psych::SyntaxError)
   end
 
-  it "should convert YAML to a data structure" do
-    yaml = <<-EOS
-- aaa
-- bbb
-- ccc
-EOS
-    result = scope.function_parseyaml([yaml])
-    expect(result).to(eq(['aaa','bbb','ccc']))
+  context 'with incorrect YAML data' do
+    it 'supports a structure for a default value' do
+      is_expected.to run.with_params('', 'a' => '1')
+                        .and_return('a' => '1')
+    end
+
+    [1, 1.2, nil, true, false, [], {}, :yaml].each do |value|
+      it "should return the default value for an incorrect #{value.inspect} (#{value.class}) parameter" do
+        is_expected.to run.with_params(value, 'default_value')
+                          .and_return('default_value')
+      end
+    end
+
+    context 'when running on modern rubies' do
+      ['---', '...', '*8', ''].each do |value|
+        it "should return the default value for an incorrect #{value.inspect} string parameter" do
+          is_expected.to run.with_params(value, 'default_value')
+                            .and_return('default_value')
+        end
+      end
+    end
   end
 end