X-Git-Url: https://git.adam-barratt.org.uk/?a=blobdiff_plain;f=3rdparty%2Fmodules%2Frabbitmq%2Fspec%2Funit%2Fpuppet%2Fprovider%2Frabbitmq_user_permissions%2Frabbitmqctl_spec.rb;h=76e9a170436685d9a8b45370914a5588246c17e3;hb=921e69100a563cf143f56a3905d8362336d939ff;hp=bdbc73e82c42bb27b364f884e53389bf70759c46;hpb=b54f52d2899c5785923c804fdfbba0782c147da4;p=mirror%2Fdsa-puppet.git

diff --git a/3rdparty/modules/rabbitmq/spec/unit/puppet/provider/rabbitmq_user_permissions/rabbitmqctl_spec.rb b/3rdparty/modules/rabbitmq/spec/unit/puppet/provider/rabbitmq_user_permissions/rabbitmqctl_spec.rb
index bdbc73e82..76e9a1704 100644
--- a/3rdparty/modules/rabbitmq/spec/unit/puppet/provider/rabbitmq_user_permissions/rabbitmqctl_spec.rb
+++ b/3rdparty/modules/rabbitmq/spec/unit/puppet/provider/rabbitmq_user_permissions/rabbitmqctl_spec.rb
@@ -1,93 +1,89 @@
-require 'puppet'
-require 'mocha'
-RSpec.configure do |config|
-  config.mock_with :mocha
-end
+require 'spec_helper'
+
 describe 'Puppet::Type.type(:rabbitmq_user_permissions).provider(:rabbitmqctl)' do
-  before :each do
-    @provider_class = Puppet::Type.type(:rabbitmq_user_permissions).provider(:rabbitmqctl)
-    @resource = Puppet::Type::Rabbitmq_user_permissions.new(
-      {:name => 'foo@bar'}
+  let(:resource) do
+    Puppet::Type::Rabbitmq_user_permissions.new(
+      name: 'foo@bar'
     )
-    @provider = @provider_class.new(@resource)
   end
-  after :each do
-    @provider_class.instance_variable_set(:@users, nil)
+  let(:provider_class) { Puppet::Type.type(:rabbitmq_user_permissions).provider(:rabbitmqctl) }
+  let(:provider) { provider_class.new(resource) }
+
+  after do
+    provider_class.instance_variable_set(:@users, nil)
   end
-  it 'should match user permissions from list' do
-    @provider.class.expects(:rabbitmqctl).with('-q', 'list_user_permissions', 'foo').returns <<-EOT
+  it 'matches user permissions from list' do
+    provider.class.expects(:rabbitmqctl).with('-q', 'list_user_permissions', 'foo').returns <<-EOT
 bar 1 2 3
 EOT
-    @provider.exists?.should == {:configure=>"1", :write=>"2", :read=>"3"}
+    expect(provider.exists?).to eq(configure: '1', write: '2', read: '3')
   end
-  it 'should match user permissions with empty columns' do
-    @provider.class.expects(:rabbitmqctl).with('-q', 'list_user_permissions', 'foo').returns <<-EOT
+  it 'matches user permissions with empty columns' do
+    provider.class.expects(:rabbitmqctl).with('-q', 'list_user_permissions', 'foo').returns <<-EOT
 bar			3
 EOT
-    @provider.exists?.should == {:configure=>"", :write=>"", :read=>"3"}
+    expect(provider.exists?).to eq(configure: '', write: '', read: '3')
   end
-  it 'should not match user permissions with more than 3 columns' do
-    @provider.class.expects(:rabbitmqctl).with('-q', 'list_user_permissions', 'foo').returns <<-EOT
+  it 'does not match user permissions with more than 3 columns' do
+    provider.class.expects(:rabbitmqctl).with('-q', 'list_user_permissions', 'foo').returns <<-EOT
 bar 1 2 3 4
 EOT
-    expect { @provider.exists? }.to raise_error(Puppet::Error, /cannot parse line from list_user_permissions/)
+    expect { provider.exists? }.to raise_error(Puppet::Error, %r{cannot parse line from list_user_permissions})
   end
-  it 'should not match an empty list' do
-    @provider.class.expects(:rabbitmqctl).with('-q', 'list_user_permissions', 'foo').returns <<-EOT
+  it 'does not match an empty list' do
+    provider.class.expects(:rabbitmqctl).with('-q', 'list_user_permissions', 'foo').returns <<-EOT
 EOT
-    @provider.exists?.should == nil
+    expect(provider.exists?).to eq(nil)
   end
-  it 'should create default permissions' do
-    @provider.instance_variable_set(:@should_vhost, "bar")
-    @provider.instance_variable_set(:@should_user, "foo")
-    @provider.expects(:rabbitmqctl).with('set_permissions', '-p', 'bar', 'foo', "''", "''", "''")
-    @provider.create
+  it 'creates default permissions' do
+    provider.instance_variable_set(:@should_vhost, 'bar')
+    provider.instance_variable_set(:@should_user, 'foo')
+    provider.expects(:rabbitmqctl).with('set_permissions', '-p', 'bar', 'foo', "''", "''", "''")
+    provider.create
   end
-  it 'should destroy permissions' do
-    @provider.instance_variable_set(:@should_vhost, "bar")
-    @provider.instance_variable_set(:@should_user, "foo")
-    @provider.expects(:rabbitmqctl).with('clear_permissions', '-p', 'bar', 'foo')
-    @provider.destroy
+  it 'destroys permissions' do
+    provider.instance_variable_set(:@should_vhost, 'bar')
+    provider.instance_variable_set(:@should_user, 'foo')
+    provider.expects(:rabbitmqctl).with('clear_permissions', '-p', 'bar', 'foo')
+    provider.destroy
   end
-  {:configure_permission => '1', :write_permission => '2', :read_permission => '3'}.each do |k,v|
+  { configure_permission: '1', write_permission: '2', read_permission: '3' }.each do |k, v|
     it "should be able to retrieve #{k}" do
-      @provider.class.expects(:rabbitmqctl).with('-q', 'list_user_permissions', 'foo').returns <<-EOT
+      provider.class.expects(:rabbitmqctl).with('-q', 'list_user_permissions', 'foo').returns <<-EOT
 bar 1 2 3
 EOT
-      @provider.send(k).should == v
+      expect(provider.send(k)).to eq(v)
     end
   end
-  {:configure_permission => '1', :write_permission => '2', :read_permission => '3'}.each do |k,v|
+  { configure_permission: '1', write_permission: '2', read_permission: '3' }.each do |k, v|
     it "should be able to retrieve #{k} after exists has been called" do
-      @provider.class.expects(:rabbitmqctl).with('-q', 'list_user_permissions', 'foo').returns <<-EOT
+      provider.class.expects(:rabbitmqctl).with('-q', 'list_user_permissions', 'foo').returns <<-EOT
 bar 1 2 3
 EOT
-      @provider.exists?
-      @provider.send(k).should == v
+      provider.exists?
+      expect(provider.send(k)).to eq(v)
     end
   end
-  {:configure_permission => ['foo', '2', '3'],
-   :read_permission      => ['1', '2', 'foo'],
-   :write_permission     => ['1', 'foo', '3']
-  }.each do |perm, columns|
+  { configure_permission: %w[foo 2 3],
+    read_permission: %w[1 2 foo],
+    write_permission: %w[1 foo 3] }.each do |perm, columns|
     it "should be able to sync #{perm}" do
-      @provider.class.expects(:rabbitmqctl).with('-q', 'list_user_permissions', 'foo').returns <<-EOT
+      provider.class.expects(:rabbitmqctl).with('-q', 'list_user_permissions', 'foo').returns <<-EOT
 bar 1 2 3
 EOT
-      @provider.resource[perm] = 'foo'
-      @provider.expects(:rabbitmqctl).with('set_permissions', '-p', 'bar', 'foo', *columns)
-      @provider.send("#{perm}=".to_sym, 'foo')
+      provider.resource[perm] = 'foo'
+      provider.expects(:rabbitmqctl).with('set_permissions', '-p', 'bar', 'foo', *columns)
+      provider.send("#{perm}=".to_sym, 'foo')
     end
   end
-  it 'should only call set_permissions once' do
-    @provider.class.expects(:rabbitmqctl).with('-q', 'list_user_permissions', 'foo').returns <<-EOT
+  it 'onlies call set_permissions once' do
+    provider.class.expects(:rabbitmqctl).with('-q', 'list_user_permissions', 'foo').returns <<-EOT
 bar 1 2 3
 EOT
-    @provider.resource[:configure_permission] = 'foo'
-    @provider.resource[:read_permission] = 'foo'
-    @provider.expects(:rabbitmqctl).with('set_permissions', '-p', 'bar', 'foo', 'foo', '2', 'foo').once
-    @provider.configure_permission='foo'
-    @provider.read_permission='foo'
+    provider.resource[:configure_permission] = 'foo'
+    provider.resource[:read_permission] = 'foo'
+    provider.expects(:rabbitmqctl).with('set_permissions', '-p', 'bar', 'foo', 'foo', '2', 'foo').once
+    provider.configure_permission = 'foo'
+    provider.read_permission = 'foo'
   end
 end
-